BenchmarkRunner should produce JSON summary file even when queries fail #1029
Conversation
andygrove
changed the title
| println(s"*** Iteration $i failed after $elapsed msec.") | ||
| queryTimes.append(-1) | ||
| exceptions.append(e.toString) | ||
| e.printStackTrace() |
There was a problem hiding this comment.
I think e.toString may omit the stack trace itself, even though it's printed. Do you think it makes sense to include them in the report? In that case we can print to a stream or writer using: https://docs.oracle.com/javase/7/docs/api/java/lang/Throwable.html#printStackTrace(java.io.PrintStream).
There was a problem hiding this comment.
So far I was able to get away with this approach because the exceptions are generally coming from the executors and the stack trace is already part of the message, but you're right, it would be better to do the full stack trace. I'll make that change today.
|
build |
|
@andygrove there's some |
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
force-pushed
the
benchmark-capture-failed-queries
branch
from
6671235
to
f9d04b5
Compare
|
build |
2 similar comments
|
build |
|
build |
|
@abellina The build is passing now. Could you re-approve? |
…il (NVIDIA#1029) * capture query plan and exceptions for failed queries Signed-off-by: Andy Grove <andygrove@nvidia.com>
…il (NVIDIA#1029) * capture query plan and exceptions for failed queries Signed-off-by: Andy Grove <andygrove@nvidia.com>
…il (NVIDIA#1029) * capture query plan and exceptions for failed queries Signed-off-by: Andy Grove <andygrove@nvidia.com>
…IDIA#1029) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
This PR updates the benchmark runner to capture query plans even when query execution fails.
This closes #1027