-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GpuShuffledSymmetricHashJoin by default #10418
Conversation
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A few nits that I don't really care about.
Table.mixedInnerJoinGatherMaps(leftKeys, rightKeys, leftTable, rightTable, | ||
compiledCondition, nullEquality) | ||
case _: InnerLike if buildSide == GpuBuildLeft => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Should we update the error message in the exception to include the build side?
build |
build |
Fixes #10243. Turns on the new symmetric hash join exec by default and fixes a few bugs that were found. One was a double-close bug, and the other is a incorrect binding of a join condition expression. This binding order bug also existed in the original GpuHashJoin code, so I fixed it there as well (and verified tests pass even if we disable symmetric hash join).