Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove isGpuBroadcastNestedLoopJoin from shims #1053

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Remove isGpuBroadcastNestedLoopJoin from shims #1053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions shims/spark300/src/main/scala/com/nvidia/spark/rapids/shims/spark300/Spark300Shims.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,6 @@ class Spark300Shims extends SparkShims {
}
}

override def isGpuBroadcastNestedLoopJoin(plan: SparkPlan): Boolean = {
plan match {
case _: GpuBroadcastNestedLoopJoinExecBase => true
case _ => false
}
}

override def isGpuShuffledHashJoin(plan: SparkPlan): Boolean = {
plan match {
case _: GpuShuffledHashJoinExec => true
Expand Down
1 change: 0 additions & 1 deletion sql-plugin/src/main/scala/com/nvidia/spark/rapids/SparkShims.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ trait SparkShims {
def getSparkShimVersion: ShimVersion
def isGpuHashJoin(plan: SparkPlan): Boolean
def isGpuBroadcastHashJoin(plan: SparkPlan): Boolean
def isGpuBroadcastNestedLoopJoin(plan: SparkPlan): Boolean
def isGpuShuffledHashJoin(plan: SparkPlan): Boolean
def isBroadcastExchangeLike(plan: SparkPlan): Boolean
def isShuffleExchangeLike(plan: SparkPlan): Boolean
Expand Down
5 changes: 3 additions & 2 deletions tests/src/test/scala/com/nvidia/spark/rapids/BroadcastNestedLoopJoinSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import com.nvidia.spark.rapids.TestUtils.findOperators
import org.apache.spark.SparkConf
import org.apache.spark.sql.functions.broadcast
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.rapids.execution.GpuBroadcastNestedLoopJoinExecBase

class BroadcastNestedLoopJoinSuite extends SparkQueryCompareTestSuite {

Expand All @@ -36,7 +37,7 @@ class BroadcastNestedLoopJoinSuite extends SparkQueryCompareTestSuite {
df3.collect()
val plan = df3.queryExecution.executedPlan

val nljCount = findOperators(plan, ShimLoader.getSparkShims.isGpuBroadcastNestedLoopJoin)
val nljCount = findOperators(plan, _.isInstanceOf[GpuBroadcastNestedLoopJoinExecBase])
assert(nljCount.size === 1)
}, conf)
}
Expand All @@ -53,7 +54,7 @@ class BroadcastNestedLoopJoinSuite extends SparkQueryCompareTestSuite {
df3.collect()
val plan = df3.queryExecution.executedPlan

val nljCount = findOperators(plan, ShimLoader.getSparkShims.isGpuBroadcastNestedLoopJoin)
val nljCount = findOperators(plan, _.isInstanceOf[GpuBroadcastNestedLoopJoinExecBase])

ShimLoader.getSparkShims.getSparkShimVersion match {
case SparkShimVersion(3, 0, 0) =>
Expand Down