Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string escaping JSON tests to the test_json_matrix #10604

Merged
merged 9 commits into from
Aug 19, 2024

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Mar 15, 2024

This contributes to #10491 and I intend to add more here, but this is just to put up what I have done so far as kind of a checkpoint.

@sameerz sameerz added the test Only impacts tests label Mar 21, 2024
@revans2 revans2 changed the base branch from branch-24.04 to branch-24.06 April 10, 2024 17:54
@revans2 revans2 changed the base branch from branch-24.06 to branch-24.10 July 30, 2024 18:17
@revans2 revans2 marked this pull request as ready for review August 13, 2024 19:22
@revans2
Copy link
Collaborator Author

revans2 commented Aug 13, 2024

build

@revans2
Copy link
Collaborator Author

revans2 commented Aug 13, 2024

I think this is good enough for now. I will go back through #10491 and add more tests on other PRs as needed.

@revans2 revans2 changed the title Add more JSON tests to the test_json_matrix Add string escaping JSON tests to the test_json_matrix Aug 13, 2024
@revans2 revans2 merged commit 92d9bbb into NVIDIA:branch-24.10 Aug 19, 2024
43 checks passed
@revans2 revans2 deleted the more_json_tests branch August 19, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants