Cleanup async state when multi-threaded shuffle readers fail #10637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
revans2
reviewed
Mar 26, 2024
| @@ -770,20 +831,27 @@ abstract class RapidsShuffleThreadedReaderBase[K, C]( | |||
|
|
|||
| private def deserializeTask(blockState: BlockState): Unit = { | |||
| val slot = RapidsShuffleInternalManagerBase.getNextReaderSlot | |||
| val tc = TaskContext.get() | |||
There was a problem hiding this comment.
This is not used and is showing as a compile error.
|
|
||
| // close any materialized BlockState objects that are holding onto netty buffers or | ||
| // file descriptors | ||
| pendingIts.foreach(_.close) |
|
build |
|
build |
| } | ||
| futures.clear() | ||
| if (fallbackIter != null) { | ||
| fallbackIter.close() |
There was a problem hiding this comment.
if this throws and failedFuture was not empty at the time, we are potentially masking the root cause
There was a problem hiding this comment.
ah good point, I can add it as suppressed, sec.
There was a problem hiding this comment.
@gerashegalov should be taken care of here: d58b471
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10631
We had some reports of file descriptors left open from the multi-threaded shuffle reader, likely due to a wave of other exceptions. I started to look at it and found that it did not handle cases when tasks were cancelled correctly, nor errors such as stream close. I added code in the task completion callback to close out any accumulated future or to-be-processed batch.
I also fixed an issue where we would leak a batch if a stream closes after we materialize the batch, but before we read the next header. I found that one because I was testing this by introducing exceptions manually.
I am going to add a test in
RapidsShuffleThreadedReaderSuiteshortly.