Remove the mixedType config for JSON as it has no downsides any longer #10716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
jlowe
reviewed
Apr 16, 2024
docs/compatibility.md
Outdated
Comment on lines
371
to
372
| Mixed types can have some problem. If an item being read could have some lines that are arrays | ||
| and others that are structs/dictionaries it is possible for an error will be thrown. |
There was a problem hiding this comment.
Suggested change
| Mixed types can have some problem. If an item being read could have some lines that are arrays | |
| and others that are structs/dictionaries it is possible for an error will be thrown. | |
| Mixed types can have some problems. If an item being read could have some lines that are arrays | |
| and others that are structs/dictionaries it is possible an error will be thrown. |
| @@ -268,6 +268,7 @@ object GpuJsonReadCommon { | |||
|
|
|||
| private def throwMismatchException(cv: ColumnView, | |||
| dt: DataType): (Option[ColumnView], Seq[AutoCloseable]) = { | |||
| ai.rapids.cudf.TableDebug.get.debug(s"JSON MISMATCH $dt", cv) | |||
There was a problem hiding this comment.
Intentional or debug code left in?
|
build |
jlowe
approved these changes
Apr 16, 2024
sameerz
added
the
task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mixedTypesAsStrings was added in when we relied on CUDF to do schema discovery when parsing JSON. That is no longer the case and there are no real downsides to it any longer. So remove the config because it is not really needed.
This patch sets it to always be on, as that is the direction we want to go in.