Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Could not find any rapids-4-spark jars in classpath" error when debugging UT in IDEA #10733

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

thirtiseven
Copy link
Collaborator

Fix #10722

There is no jar in classpath when debugging UT in IDE, so following require fails:

require(revisionMap.size > 0, s"Could not find any $jarName jars in the classpath")

This PR removes this require and modifies the related logic to make debugging in IDEA work again.

Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
@thirtiseven
Copy link
Collaborator Author

build

@gerashegalov
Copy link
Collaborator

gerashegalov commented Apr 24, 2024

Another way is to do it similar to isTesting to adjust conditions that are legitimately different between the test and production.

This PR relaxes the requirement for production and the test environment where it was already working without it

@thirtiseven
Copy link
Collaborator Author

build

@thirtiseven
Copy link
Collaborator Author

failed because #10738

@thirtiseven
Copy link
Collaborator Author

build

@thirtiseven thirtiseven merged commit fe22933 into NVIDIA:branch-24.06 Apr 24, 2024
44 checks passed
@thirtiseven thirtiseven deleted the fix_idea_debugging branch April 24, 2024 12:08
@sameerz sameerz added the test Only impacts tests label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] "Could not find any rapids-4-spark jars in classpath" error when debugging UT in IDEA
4 participants