Add number normalization test and address followup for getJsonObject #10800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
res-life
reviewed
May 13, 2024
| else: | ||
| return float(x) | ||
| for i in range(len(gpu_res)): | ||
| assert math.isclose(json_string_to_float(gpu_res[i][0]), json_string_to_float(cpu_res[i][0])) |
There was a problem hiding this comment.
Nit: Add a comment like:
verify relatively diff < 1.0e-7
|
How long this test case will run? < one minute? |
Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
Signed-off-by: Haoyang Li <haoyangl@nvidia.com>
Yes. We used to run a case locally with a very large length, so it was slow, now it run fast with default length. |
|
build |
res-life
approved these changes
May 13, 2024
sameerz
added
the
task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10688
closes #10646
A minor follow-up pr for getJsonObject
This pr: