Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Inheritance Shadowing to add support for Spark 4.0.0 [databricks] #10829

Merged
merged 2 commits into from
May 17, 2024

Conversation

razajafri
Copy link
Collaborator

This PR fixes compilation issues related to Inheritance Shadowing introduced in Scala 2.13 in which an inherited member from a parent class or trait can shadow another member declared in the outer scope. For more details read https://docs.scala-lang.org/scala3/guides/migration/incompat-other-changes.html

To fix we access the member conf using this qualifier

contributes to #9259

Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri razajafri requested a review from jlowe May 16, 2024 19:18
@sameerz sameerz added the Spark 4.0+ Spark 4.0+ issues label May 16, 2024
Copy link
Collaborator

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jlowe
Copy link
Member

jlowe commented May 16, 2024

build

@razajafri razajafri merged commit 4276bd8 into NVIDIA:branch-24.06 May 17, 2024
44 of 45 checks passed
@razajafri razajafri deleted the SP-9259-shadow-inheritance branch May 17, 2024 18:14
@razajafri razajafri self-assigned this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spark 4.0+ Spark 4.0+ issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants