-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prototype for new design LORE (with LORE id) #10999
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build |
build |
binmahone
force-pushed
the
lore2_withloreid
branch
from
June 12, 2024 02:20
4ce8ada
to
4cbd79c
Compare
Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org> refine code, broken Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org> fix Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org> complete version 1 Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org> Introduce lore id Introduce lore id Fix type Fix type with loreid Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org> clean ut Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org> refine log Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org> clean Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org> fix ut Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org> fix idgen Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>
Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>
binmahone
force-pushed
the
lore2_withloreid
branch
from
June 25, 2024 07:24
ed07234
to
654b7ad
Compare
This was referenced Jun 25, 2024
build |
1 similar comment
build |
build |
build |
build |
1 similar comment
build |
Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>
build |
Signed-off-by: Hongbin Ma (Mahone) <mahongbin@apache.org>
build |
query perf pass @wjxiz1992 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a enhanced version of #10983, allowing uesr to specify what operator to dump using the LORE ID (By @liurenjie1024 ). Check more explaination of LOREID at #10942 (comment)
we'll choose this PR or #10983 to use at customer site