Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed array_tests for Spark 4.0.0 [databricks] #11048

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Fixed array_tests for Spark 4.0.0 [databricks] #11048

merged 3 commits into from
Jun 28, 2024

Conversation

razajafri
Copy link
Collaborator

This PR fixes array_test by setting the spark.sql.ansi.enabled to false and some exception messages were changed.

fixes #11007

@razajafri
Fixed array_tests
2f6b50b
@razajafri
Signing off
9fa7ad3 
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
@razajafri razajafri changed the title Fixed array_tests [databricks] Fixed array_tests for Spark 4.0.0 [databricks] Jun 13, 2024
@sameerz sameerz added the Spark 4.0+ Spark 4.0+ issues label Jun 13, 2024
jlowe
jlowe reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description mentions that the ANSI config was set to false to fix some of these tests, but I don't see that change?

@razajafri
Copy link
Collaborator Author

build

@razajafri
Copy link
Collaborator Author

@jlowe I was waiting on #11006 to be merged. Can you PTAL on this

@razajafri razajafri merged commit dd62000 into NVIDIA:branch-24.08 Jun 28, 2024
45 checks passed
@razajafri razajafri deleted the SP-11007-array-test branch June 28, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees
No one assigned
Labels
Spark 4.0+ Spark 4.0+ issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix tests failures in array_test.py
3 participants
@razajafri @jlowe @sameerz