fix bug where 'now' had same value as 'today' for timestamps #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
|
test failures seem related |
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
jlowe
reviewed
Nov 18, 2020
sql-plugin/src/main/scala/com/nvidia/spark/rapids/DateUtils.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Andy Grove <andygrove@nvidia.com>
jlowe
approved these changes
Nov 18, 2020
|
I expect this needs to be upmerged to branch-0.3 in order for CI to pass. |
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
sperlingxx
pushed a commit
to sperlingxx/spark-rapids
that referenced
this pull request
Nov 20, 2020
…1159) * fix bug where 'now' had same value as 'today' for timestamps Signed-off-by: Andy Grove <andygrove@nvidia.com> * fix regressions Signed-off-by: Andy Grove <andygrove@nvidia.com> * Remove hard-coded UTC timezone when parsing special dates Signed-off-by: Andy Grove <andygrove@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…1159) * fix bug where 'now' had same value as 'today' for timestamps Signed-off-by: Andy Grove <andygrove@nvidia.com> * fix regressions Signed-off-by: Andy Grove <andygrove@nvidia.com> * Remove hard-coded UTC timezone when parsing special dates Signed-off-by: Andy Grove <andygrove@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…1159) * fix bug where 'now' had same value as 'today' for timestamps Signed-off-by: Andy Grove <andygrove@nvidia.com> * fix regressions Signed-off-by: Andy Grove <andygrove@nvidia.com> * Remove hard-coded UTC timezone when parsing special dates Signed-off-by: Andy Grove <andygrove@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
* Init version 23.08.0-SNAPSHOT Signed-off-by: Peixin Li <pxli@nyu.edu> * include doc update Signed-off-by: Peixin Li <pxli@nyu.edu> --------- Signed-off-by: Peixin Li <pxli@nyu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Grove andygrove@nvidia.com
When parsing dates, the special values
nowandtodayhave the same value, but for timestamps,nowshould reflect the current time andtodayshould reflect the start of the day.I also moved more date/time handling from GpuCast to DateUtils.
This closes #1110