Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource leaks in unit tests #1181

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Nov 20, 2020

Fixes a number of leaks in the unit tests.

This is dependent upon the ColumnBuilder close fix in rapidsai/cudf#6826 being published in cudf.

@jlowe jlowe added the test Only impacts tests label Nov 20, 2020
@jlowe jlowe added this to the Nov 9 - Nov 20 milestone Nov 20, 2020
@jlowe jlowe self-assigned this Nov 20, 2020
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@pxLi
Copy link
Collaborator

pxLi commented Nov 23, 2020

build

@jlowe jlowe marked this pull request as ready for review November 23, 2020 19:54
@jlowe
Copy link
Member Author

jlowe commented Nov 23, 2020

build

@jlowe jlowe merged commit ae1483d into NVIDIA:branch-0.3 Nov 23, 2020
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe deleted the fix-test-leaks branch September 10, 2021 15:41
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
…IDIA#1181)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants