[REVIEW] init changelog 0.3 [skip ci] #1370
Conversation
pxLi
changed the title
pxLi
requested review from
sameerz,
tgravescs,
GaryShen2008,
jlowe and
revans2
CHANGELOG.md
Outdated
| |[#1158](https://github.com/NVIDIA/spark-rapids/issues/1158)|[FEA] Better documentation on type support| | ||
| |[#57](https://github.com/NVIDIA/spark-rapids/issues/57)|[FEA] Support INT96 for parquet reads and writes| | ||
| |[#830](https://github.com/NVIDIA/spark-rapids/issues/830)|[FEA] commonize the version checking in the integration tests| | ||
| |[#817](https://github.com/NVIDIA/spark-rapids/issues/817)|[FEA] Create integration test build against Dataproc| |
There was a problem hiding this comment.
Why are features also tagged with test or build put into this section? I am fine if that is what the requirements ask for. It just feels like they are not something that end users would look for in the Features section.
There was a problem hiding this comment.
yeah, thats something we may need to re-adjust the label here, the tool was just generating doc by label and project
There was a problem hiding this comment.
I reviewed the labels on the issues and removed the feature label from those issues that were focused on tests.
CHANGELOG.md
Outdated
| @@ -34,6 +43,8 @@ Generated on 2020-11-30 | |||
| ### Performance | |||
| ||| | |||
| |:---|:---| | |||
| |[#1048](https://github.com/NVIDIA/spark-rapids/issues/1048)|[FEA] Benchmark runner should upload summary file and Spark event log to s3| | |||
There was a problem hiding this comment.
IMO the performance section of the release notes should highlight changes that directly impact the performance of the product. Most of the things listed here are not that.
There was a problem hiding this comment.
@sameerz plz help check the labels here, thx!
There was a problem hiding this comment.
I asked @pxLi to modify the changelog script to not pick up the benchmark label for performance features.
Signed-off-by: Peixin Li <pxli@nyu.edu>
|
updated to latest |
|
build |
* changelog 0.3 Signed-off-by: Peixin Li <pxli@nyu.edu>
* changelog 0.3 Signed-off-by: Peixin Li <pxli@nyu.edu>
…IDIA#1370) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Signed-off-by: Peixin Li pxli@nyu.edu
init changelog for 0.3 release w/
GITHUB_TOKEN=<xxx> scripts/generate-changelog --releases=0.3,0.2,0.1To preview the CHANGELOG: https://github.com/pxLi/spark-rapids/blob/changelog-0.3/CHANGELOG.md.
Please help review the issues and PR, correct if any invalid titles, labels or project info. Thanks!