Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds in basic support for decimal sort, sum, and some shuffle #1380

Merged
merged 3 commits into from
Dec 14, 2020

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Dec 11, 2020

This fixes #1316

It also does a lot for #1328 but is not complete because there is a bug in cudf rapidsai/cudf#6996 that once it is fixed we can enable hash partitioning for decimal columns.

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@revans2 revans2 added the SQL part of the SQL/Dataframe plugin label Dec 11, 2020
@revans2 revans2 added this to the Dec 7 - Dec 18 milestone Dec 11, 2020
@revans2 revans2 self-assigned this Dec 11, 2020
@revans2
Copy link
Collaborator Author

revans2 commented Dec 11, 2020

build

Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about debug code and the test failures need to be investigated, but otherwise lgtm.

@revans2
Copy link
Collaborator Author

revans2 commented Dec 14, 2020

build

@revans2 revans2 merged commit 5c43fd3 into NVIDIA:branch-0.4 Dec 14, 2020
@revans2 revans2 deleted the decimal_sort_and_agg branch December 14, 2020 17:18
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
…#1380)

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
…#1380)

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
…IDIA#1380)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SQL part of the SQL/Dataframe plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants