-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better GPU Cast type checks #1402
Conversation
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
build |
👎 Promotion blocked, new vulnerability foundVulnerability report
|
"2018-1random_text", | ||
"2018-11-08random_text", | ||
"2018-11-9random_text", | ||
// `yyyy-[m]m-[d]dT*` in some version of Spark this is valid and in others it is not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the only time we are excluding these values from the test is when ansiEnabled=true
rather than excluding them for particular Spark versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, version 3.1 + when ANSI is enabled they now cause an exception to be thrown. Because the test this is for is "Test all supported casts with in-range values" I assumed that is fine. If you want me to allow different values for different versions I can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is good but the comment confused me so I just wanted to make sure that I understood this correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update the comment to explain what is happening.
build |
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
…IDIA#1402) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
This automates generating the docs for cast. It also updates the tests in cast so that they go off of the types listed as supported.
I did take one of the changes from #1396 to make this work (Thanks @andygrove for that work)