Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use decimals in tpc-ds csv to parquet conversion #1409

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

andygrove
Copy link
Contributor

Signed-off-by: Andy Grove andygrove@nvidia.com

Add useDecimalType parameter to TPC-DS csvToParquet and csvToOrc so that files can be generated with decimal type instead of double.

I confirmed that the documentation does not need updating since this new parameter has a default value.

Signed-off-by: Andy Grove <andygrove@nvidia.com>
@andygrove andygrove added the benchmark Benchmarking, benchmarking tools label Dec 16, 2020
@andygrove andygrove added this to the Dec 7 - Dec 18 milestone Dec 16, 2020
@andygrove andygrove self-assigned this Dec 16, 2020
Signed-off-by: Andy Grove <andygrove@nvidia.com>
@jlowe
Copy link
Member

jlowe commented Dec 16, 2020

build

@andygrove andygrove merged commit c0ac27c into NVIDIA:branch-0.4 Dec 16, 2020
@andygrove andygrove deleted the tpcds-decimal branch February 11, 2021 22:16
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
…A#1409)

* add option to use decimals in tpc-ds csv to parquet conversion

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* change ordering of params

Signed-off-by: Andy Grove <andygrove@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
…A#1409)

* add option to use decimals in tpc-ds csv to parquet conversion

Signed-off-by: Andy Grove <andygrove@nvidia.com>

* change ordering of params

Signed-off-by: Andy Grove <andygrove@nvidia.com>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
…IDIA#1409)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Benchmarking, benchmarking tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants