Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the number of partitions to zero when a range is empty #1542

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Jan 15, 2021

This fixes #1451
and is essentially the same fix done for SPARK-32822

I manually tested this by running the query in the PR apache/spark#29681

spark.range(1, 1, 1, 1000).rdd.getNumPartitions
res0: Int = 0

We don't support code gen so it was showing up all the time for us.

If someone really wants an automated test I can add it in, but it is totally different from all of the other tests that we have run.

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@revans2 revans2 added this to the Jan 18 - Jan 29 milestone Jan 15, 2021
@revans2 revans2 self-assigned this Jan 15, 2021
@revans2
Copy link
Collaborator Author

revans2 commented Jan 15, 2021

build

@revans2
Copy link
Collaborator Author

revans2 commented Jan 15, 2021

build

Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@revans2 revans2 merged commit 4df63a5 into NVIDIA:branch-0.4 Jan 15, 2021
@revans2 revans2 deleted the fix_empty_range_parts branch January 15, 2021 22:44
@sameerz sameerz added audit_3.1.0 task Work required that improves the product but is not user facing labels Jan 17, 2021
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
…#1542)

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
…#1542)

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
…IDIA#1542)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit_3.1.0 task Work required that improves the product but is not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Spark 3.1.0 - GpuRangeExec pull in fix SPARK-32822
5 participants