Decimal support for add and subtract #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Lee <ryanlee@nvidia.com>
rwlee
force-pushed
the
rwlee/decimal_binops
branch
from
2bb5498
to
6592b2e
Compare
revans2
reviewed
Jan 21, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/decimalExpressions.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/decimalExpressions.scala
Outdated
Show resolved
Hide resolved
tests/src/test/scala/com/nvidia/spark/rapids/unit/DecimalUnitTest.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Lee <ryanlee@nvidia.com>
10 tasks
revans2
approved these changes
Jan 21, 2021
|
build |
jlowe
approved these changes
Jan 21, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Ryan Lee <ryanlee@nvidia.com> Co-authored-by: Robert (Bobby) Evans <bobby@apache.org>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Ryan Lee <ryanlee@nvidia.com> Co-authored-by: Robert (Bobby) Evans <bobby@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines work from @sperlingxx #976 and @revans2 changes to resolve precision mismatches when running on the GPU. Merging this should close #976, as the necessary bits have already been merged or were copied over and modified for this PR.