When PTDS is enabled, print warning if the allocator is not ARENA #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
abellina
force-pushed
the
print_warning_for_ptds_and_pooled_allocator
branch
from
2052885
to
d551641
Compare
jlowe
reviewed
Feb 5, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuDeviceManager.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsConf.scala
Outdated
Show resolved
Hide resolved
sameerz
added
the
task
|
build |
Per-thread -> Per-Thread Co-authored-by: Jason Lowe <jlowe@nvidia.com>
|
build |
jlowe
approved these changes
Feb 8, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…IDIA#1677) * When PTDS is enabled, print warning if the allocator is not ARENA Signed-off-by: Alessandro Bellina <abellina@nvidia.com> * Apply suggestions from code review Per-thread -> Per-Thread Co-authored-by: Jason Lowe <jlowe@nvidia.com> Co-authored-by: Jason Lowe <jlowe@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…IDIA#1677) * When PTDS is enabled, print warning if the allocator is not ARENA Signed-off-by: Alessandro Bellina <abellina@nvidia.com> * Apply suggestions from code review Per-thread -> Per-Thread Co-authored-by: Jason Lowe <jlowe@nvidia.com> Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alessandro Bellina abellina@nvidia.com
Add a disclaimer for #1141 (
cudaErrorillegalAddresswhen PTDS and DEFAULT are used) for now while we root cause it.