Build python output schema from udf expressions #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the result attributes are NOT always equal to the python output schema. For example, on databricks when projecting only one column from a python UDF output where containing multiple result columns, there will be only one attribute in the result attributes for the projecting output, but the output schema for this python udf contains multiple columns. Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
|
build |
1 similar comment
|
build |
revans2
previously approved these changes
Feb 23, 2021
| @@ -555,7 +555,7 @@ case class GpuArrowEvalPythonExec( | |||
|
|
|||
| // cache in a local to avoid serializing the plan | |||
| val inputSchema = child.output.toStructType | |||
| val pythonOutputSchema = StructType.fromAttributes(resultAttrs) | |||
| val pythonOutputSchema = StructType.fromAttributes(udfs.map(_.resultAttribute)) | |||
There was a problem hiding this comment.
nit: Great catch on this by the way. Could we add some comments here explaining what is happening and why we are not using resultAttrs that was passed in? If I made the mistake before then a comment will hopefully help someone not break it going back again, especially if it only shows up for databricks.
There was a problem hiding this comment.
Good suggestion, updated.
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
build |
revans2
approved these changes
Feb 24, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the Python output schema from the Python UDF expressions instead of the plan result attributes, because the result attributes are NOT always equal to the Python output schema.
For example, on databricks when projecting only one column from a Python UDF output where containing multiple result columns, there will be only one attribute in the result attributes for the projecting output, but the output schema for this Python UDF contains multiple columns.
Closes #1644
Signed-off-by: Firestarman firestarmanllc@gmail.com