Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax cudf version check for patch-level versions #1930

Merged
merged 8 commits into from
Mar 18, 2021
Merged

Relax cudf version check for patch-level versions #1930

merged 8 commits into from
Mar 18, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Mar 12, 2021

Fixes #1921.

This updates the cudf version check to be lenient on patch-level differences. The patch level, and any sub-version afterwards, can be different as long as it is more recent (i.e.: greater) than the requested version.

@jlowe
Relax cudf version check for patch-level versions
88c319a 
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe added the SQL part of the SQL/Dataframe plugin label Mar 12, 2021
@jlowe jlowe added this to the Mar 1 - Mar 12 milestone Mar 12, 2021
@jlowe jlowe self-assigned this Mar 12, 2021
@jlowe
Copy link
Member Author

jlowe commented Mar 12, 2021

build

@jlowe jlowe requested a review from tgravescs March 12, 2021 22:52
@jlowe
Copy link
Member Author

jlowe commented Mar 12, 2021

build

gerashegalov
gerashegalov previously approved these changes Mar 13, 2021
View reviewed changes
Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlowe jlowe requested a review from gerashegalov March 13, 2021 00:56
tgravescs
tgravescs previously approved these changes Mar 13, 2021
View reviewed changes
@jlowe
Copy link
Member Author

jlowe commented Mar 15, 2021

build

gerashegalov
gerashegalov approved these changes Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlowe
Copy link
Member Author

jlowe commented Mar 15, 2021 •
edited
Loading

@pxLi can you look into the signoff check failure that also succeeded? 🤔 The successful run should have cleared the older error but somehow did not.

@jlowe
Copy link
Member Author

jlowe commented Mar 16, 2021

build

@jlowe
Copy link
Member Author

jlowe commented Mar 16, 2021

build

1 similar comment
@jlowe
Copy link
Member Author

jlowe commented Mar 16, 2021

build

@pxLi
Copy link
Collaborator

pxLi commented Mar 17, 2021

@pxLi can you look into the signoff check failure that also succeeded? 🤔 The successful run should have cleared the older error but somehow did not.

I see it passed now, there could be some delay for the github action to updated the status

@pxLi
Copy link
Collaborator

pxLi commented Mar 17, 2021

build

@pxLi
Copy link
Collaborator

pxLi commented Mar 17, 2021

CI failed. should be waiting for #1889

@jlowe
Copy link
Member Author

jlowe commented Mar 17, 2021

I see it passed now, there could be some delay for the github action to updated the status

It passed because I pushed a new merge commit which caused it to run again.

@pxLi
Copy link
Collaborator

pxLi commented Mar 17, 2021

I see it passed now, there could be some delay for the github action to updated the status

It passed because I pushed a new merge commit which caused it to run again.

yep, I checked the github status, there were 2 terrible incidents for github action recently,
https://www.githubstatus.com/incidents/s654n76c1bwr
https://www.githubstatus.com/incidents/wdhkj70kynwk

@jlowe
Copy link
Member Author

jlowe commented Mar 18, 2021

build

@jlowe jlowe merged commit 2e03664 into NVIDIA:branch-0.5 Mar 18, 2021
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@jlowe
Relax cudf version check for patch-level versions (NVIDIA#1930)
89eb0b0 
* Relax cudf version check for patch-level versions

Signed-off-by: Jason Lowe <jlowe@nvidia.com>

* whitespace

* cleanup and use NumberFormatException

* Cleanup checking with Try and startsWith

* Add tests for many patch levels
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@jlowe
Relax cudf version check for patch-level versions (NVIDIA#1930)
39e9a41 
* Relax cudf version check for patch-level versions

Signed-off-by: Jason Lowe <jlowe@nvidia.com>

* whitespace

* cleanup and use NumberFormatException

* Cleanup checking with Try and startsWith

* Add tests for many patch levels
@jlowe jlowe deleted the cudf-fuzzy-check branch September 10, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerashegalov gerashegalov gerashegalov approved these changes

@revans2 revans2 revans2 approved these changes

@tgravescs tgravescs tgravescs left review comments

Assignees

@jlowe jlowe

Labels
SQL part of the SQL/Dataframe plugin
Projects
None yet
Milestone
Mar 15 - March 26
Development

Successfully merging this pull request may close these issues.

[FEA] cudf version check should be lenient on later patch version
6 participants
@jlowe @pxLi @gerashegalov @revans2 @tgravescs @sameerz