Upgrade ScalaTest plugin to respect JAVA_HOME #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gera Shegalov <gera@apache.org>
gerashegalov
added
test
gerashegalov
requested review from
jlowe,
NvTimLiu,
revans2 and
tgravescs
as code owners
|
build |
|
❌ ✔️ |
jlowe
approved these changes
Apr 7, 2021
pxLi
approved these changes
Apr 7, 2021
razajafri
approved these changes
Apr 7, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Gera Shegalov <gera@apache.org>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Gera Shegalov <gera@apache.org>
gerashegalov
added a commit
that referenced
this pull request
Jun 10, 2021
Tools should not unnecessarily override parent pom versions Recurrence of #2088 Signed-off-by: Gera Shegalov <gera@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gera Shegalov gera@apache.org
Spark/RAPIDS plugin contains tests requiring special settings for Java 11. E.g., by default the test
test GpuArrowColumnarBatchBuilder retains reference of ArrowBuftriggers an error with JDK11.If we use JDK11 by default, setting
JAVA_HOMEto a JDK8 location does not fix the problem due toscalatest/scalatest-maven-plugin#69. Upgrading to the ScalaTest plugin version
to consume the fix