fix refcount when materializing device buffer from GDS #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rong Ou <rong.ou@gmail.com>
rongou
added
bug
jlowe
reviewed
Apr 8, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsGdsStore.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Rong Ou <rong.ou@gmail.com>
|
build |
jlowe
approved these changes
Apr 8, 2021
abellina
approved these changes
Apr 8, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* fix refcount when materializing device buffer from GDS Signed-off-by: Rong Ou <rong.ou@gmail.com> * really fix it Signed-off-by: Rong Ou <rong.ou@gmail.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* fix refcount when materializing device buffer from GDS Signed-off-by: Rong Ou <rong.ou@gmail.com> * really fix it Signed-off-by: Rong Ou <rong.ou@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rong Ou rong.ou@gmail.com
Ideally this should be covered by a test, but right now we can't run GDS tests with the plugin. I added an action item in #1445 to add tests once the CI/CD pipeline is set up to run GDS tests.