Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified the Download page for 0.4.1 and updated doc to point to K8s guide #2114

Merged
merged 12 commits into from
Apr 13, 2021
Merged

Modified the Download page for 0.4.1 and updated doc to point to K8s guide #2114

merged 12 commits into from
Apr 13, 2021

Conversation

viadea
Copy link
Collaborator

@viadea viadea commented Apr 10, 2021

No description provided.

viadea and others added 12 commits March 5, 2021 21:28
@viadea
doing some test
f80cb6a
@viadea
Revert "doing some test"
47fdca4 
This reverts commit f80cb6a.

Rollback changes to README
@viadea
Update download.md
ede56bd 
Add Version Matrix in a spreadsheet.
@viadea
Update download.md
744bb42 
Add Version Matrix in a spreadsheet.

Signed-off-by: Hao Zhu <viadeazhu@gmail.com>
@viadea
Merge branch 'branch-0.5' of github.com:viadea/spark-rapids into bran…
521921e 
…ch-0.5
@viadea
Revert "Update download.md"
4a82093 
This reverts commit 744bb42.
@viadea
Merge remote-tracking branch 'upstream/branch-0.5' into branch-0.5
ca4d040
@viadea
Merge remote-tracking branch 'upstream/branch-0.5' into branch-0.5
e0ed7ad
@viadea
Merge remote-tracking branch 'upstream/branch-0.5' into branch-0.5
8ef30d1
@viadea
Merge remote-tracking branch 'upstream/branch-0.5' into branch-0.5
bc416fb
@viadea
Update download page format for 0.4.1
786d10c 
Update download page format for 0.4.1 with the same format as other versions.
@viadea
Update the Doc to point to new K8s doc
1f31d04 
Update the Doc to point to new K8s doc
@viadea viadea requested review from jlowe and sameerz April 10, 2021 05:16
@viadea viadea mentioned this pull request Apr 10, 2021
Closed
@tgravescs
Copy link
Collaborator

this seems fine but one thing I wonder if it would be more consistent to split out yarn and standalone into own sections as well that way when I go to the docs and twisty the getting started I see all of them rather then having to go into on Prem non for just yarn and standalone. That should be different PR but if folks agree we should file a followup. @sameerz @jlowe thoughts?

@tgravescs
Copy link
Collaborator

build

jlowe
jlowe approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would be more consistent to split out yarn and standalone into own sections as well that way when I go to the docs and twisty the getting started I see all of them rather then having to go into on Prem non for just yarn and standalone. That should be different PR but if folks agree we should file a followup.

Agree, I'd like to see each setup treated consistently.

@sameerz sameerz added the documentation Improvements or additions to documentation label Apr 13, 2021
@sameerz sameerz added this to the Apr 12 - Apr 23 milestone Apr 13, 2021
@sameerz sameerz mentioned this pull request Apr 13, 2021
Open
@sameerz
Copy link
Collaborator

sameerz commented Apr 13, 2021

I wonder if it would be more consistent to split out yarn and standalone into own sections as well that way when I go to the docs and twisty the getting started I see all of them rather then having to go into on Prem non for just yarn and standalone. That should be different PR but if folks agree we should file a followup.

Agree, I'd like to see each setup treated consistently.

Agree, filed an issue #2121

@sameerz sameerz merged commit 5114bd3 into NVIDIA:branch-0.5 Apr 13, 2021
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@viadea
Modified the Download page for 0.4.1 and updated doc to point to K8s …
2a68db5 
…guide (NVIDIA#2114)

* doing some test

* Revert "doing some test"

This reverts commit f80cb6a.

Rollback changes to README

* Update download.md

Add Version Matrix in a spreadsheet.

* Update download.md

Add Version Matrix in a spreadsheet.

Signed-off-by: Hao Zhu <viadeazhu@gmail.com>

* Revert "Update download.md"

This reverts commit 744bb42.

* Update download page format for 0.4.1

Update download page format for 0.4.1 with the same format as other versions.

* Update the Doc to point to new K8s doc

Update the Doc to point to new K8s doc
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@viadea
Modified the Download page for 0.4.1 and updated doc to point to K8s …
0eb02d9 
…guide (NVIDIA#2114)

* doing some test

* Revert "doing some test"

This reverts commit f80cb6a.

Rollback changes to README

* Update download.md

Add Version Matrix in a spreadsheet.

* Update download.md

Add Version Matrix in a spreadsheet.

Signed-off-by: Hao Zhu <viadeazhu@gmail.com>

* Revert "Update download.md"

This reverts commit 744bb42.

* Update download page format for 0.4.1

Update download page format for 0.4.1 with the same format as other versions.

* Update the Doc to point to new K8s doc

Update the Doc to point to new K8s doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@tgravescs tgravescs tgravescs approved these changes

@sameerz sameerz sameerz approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Apr 12 - Apr 23
Development

Successfully merging this pull request may close these issues.
4 participants
@viadea @tgravescs @sameerz @jlowe