Fix the failing test test_window on Databricks
#2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By making the 'outReference' be lazy. Because on Databricks, it will get some invalid expressions in the 'projectList' if binding the reference on driver side. E.g. 'none#0L', 'none@1L'. Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
Verification on DB is running ... https://blossom.nvidia.com/sw-gpu-spark-jenkins/view/Testing/job/lc-db/ . |
|
build |
pxLi
approved these changes
May 24, 2021
revans2
reviewed
May 24, 2021
There was a problem hiding this comment.
I am happy that this was fixed, but it would have been nice to add a comment to the outReferences explaining why it needs to be lazy. Often when there a subtle bugs like this it is easy for someone to accidentally undo the fix without a warning that there is a problem to be aware of.
|
Agree with Bobby, I tried to make sure in the new shim that we document changes made specific to Databricks, so if we can followup and add comment that would be great |
|
Made the PR #2496 to add the comments. |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
By making the 'outReference' be lazy. Because on Databricks, it will get some invalid expressions in the 'projectList' if binding the reference on driver side. E.g. 'none#0L', 'none@1L'. Signed-off-by: Firestarman <firestarmanllc@gmail.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
By making the 'outReference' be lazy. Because on Databricks, it will get some invalid expressions in the 'projectList' if binding the reference on driver side. E.g. 'none#0L', 'none@1L'. Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR is to fix the failing test
test_windowon Databricks by making theoutReferencebe lazy.Because on Databricks, it will get some invalid expressions (e.g.
none#0L,none@1L.) in theprojectListif binding the references on the driver side.closes #2372
Signed-off-by: Firestarman firestarmanllc@gmail.com