Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary logging for Dataproc round robin fallback issue #2490

Merged
merged 1 commit into from
May 24, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented May 24, 2021

This adds temporary logging to help debug #2407. The test is only failing in Dataproc and I am unable to reproduce it despite trying to follow the Dataproc scripts closely. This logging should help explain whether we really are failing to fallback or if this is a case of capturing the wrong plan.

After this is merged, I'll file a followup to ensure the logging is removed before 21.06 is released.

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe self-assigned this May 24, 2021
@jlowe
Copy link
Member Author

jlowe commented May 24, 2021

build

Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that you know what logging you need/want.

@jlowe jlowe merged commit 1cf741b into NVIDIA:branch-21.06 May 24, 2021
@sameerz sameerz added the test Only impacts tests label May 27, 2021
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@jlowe jlowe deleted the dataproc-round-robin-dbg-print branch September 10, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants