Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments for lazy binding in WindowInPandas #2496

Merged
merged 1 commit into from
May 25, 2021
Merged

Add comments for lazy binding in WindowInPandas #2496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...301db/src/main/scala/com/nvidia/spark/rapids/shims/spark301db/GpuWindowInPandasExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, NVIDIA CORPORATION.
* Copyright (c) 2020-2021, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -54,6 +54,10 @@ case class GpuWindowInPandasExec(
}
}

// On Databricks, binding the references on driver side will get some invalid expressions
// (e.g. none#0L, none@1L) in the `projectList`, causing failures in `test_window` test.
// So need to do the binding for `projectList` lazily, and the binding will actually run
// on executors now.
private lazy val outReferences = {
val allExpressions = windowFramesWithExpressions.map(_._2).flatten
val references = allExpressions.zipWithIndex.map { case (e, i) =>
Expand Down
4 changes: 4 additions & 0 deletions ...org/apache/spark/sql/rapids/execution/python/shims/spark310db/GpuWindowInPandasExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ case class GpuWindowInPandasExec(
}
}

// On Databricks, binding the references on driver side will get some invalid expressions
// (e.g. none#0L, none@1L) in the `projectList`, causing failures in `test_window` test.
// So need to do the binding for `projectList` lazily, and the binding will actually run
// on executors now.
private lazy val outReferences = {
val allExpressions = windowFramesWithExpressions.map(_._2).flatten
val references = allExpressions.zipWithIndex.map { case (e, i) =>
Expand Down