Add Struct support for ParquetWriter #2514
Conversation
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
| @@ -2815,7 +2815,8 @@ object GpuOverrides { | |||
| exec[DataWritingCommandExec]( | |||
| "Writing data", | |||
| ExecChecks((TypeSig.commonCudfTypes + | |||
| TypeSig.DECIMAL.withPsNote(TypeEnum.DECIMAL, "Only supported for Parquet")).nested(), | |||
| TypeSig.DECIMAL.withPsNote(TypeEnum.DECIMAL, "Only supported for Parquet") + | |||
| TypeSig.STRUCT.withPsNote(TypeEnum.STRUCT, "Only supported for Parquet")).nested(), | |||
There was a problem hiding this comment.
Are we missing a test? When the struct support went in, the fact that we forgot to update this should have been caught by the test.
There was a problem hiding this comment.
Thanks for pointing this out @jlowe I remembered that we added struct support for GpuInMemoryTableScanExec and confused it with DataWritingCommandExec. We have to turn this on as part of this PR. I have updated the PR name to reflect it
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
razajafri
changed the title
|
build |
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
| pytest.param([decimal_gen_default, parquet_basic_struct_gen, | ||
| StructGen([['child0', StructGen([['child1', byte_gen]])]]), | ||
| decimal_gen_scale_precision, decimal_gen_same_scale_precision, decimal_gen_64bit], | ||
| marks=pytest.mark.allow_non_gpu("CoalesceExec"))] |
There was a problem hiding this comment.
Why is CoalesceExec not on the GPU? and is there an open issue that will put it on the GPU? If not we should file one and reference it here. If so we should just reference it here.
There was a problem hiding this comment.
I assume this is fixed by #2530 which added struct support for coalesce.
There was a problem hiding this comment.
I have updated the PR to not allow Coalesce with Structs to run on CPU
There was a problem hiding this comment.
The code still has allow_non_gpu("CoalesceExec")?
There was a problem hiding this comment.
no, its not refflecting it here for some reason, unless you go to the last commit
There was a problem hiding this comment.
Are you referring to a commit that has yet to be pushed to his PR? Because I still see it in https://github.com/NVIDIA/spark-rapids/pull/2514/files and at https://github.com/razajafri/spark-rapids-1/blob/parquet-doc/integration_tests/src/main/python/parquet_write_test.py#L49
There was a problem hiding this comment.
OK you are seeing the latest, I wasn't seeing it until I looked at the commit specifically.
So that is needed because CoalesceExec doesn't support Decimals yet
There was a problem hiding this comment.
So that is needed because CoalesceExec doesn't support Decimals yet
#2531 explicitly states it adds decimal support and appears to be testing it. So if that is somehow not working in practice an issue needs to be filed and fixed.
There was a problem hiding this comment.
Sorry for wasting your time. I didn't see _commonTypes was added and thought it was TypeSig.commonCudfTypes
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
…ts now Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
|
build |
* updated Parquet writer support docs Signed-off-by: Raza Jafri <rjafri@nvidia.com> * adding Struct to allow list for ParquetWriter Signed-off-by: Raza Jafri <rjafri@nvidia.com> * add nested struct test Signed-off-by: Raza Jafri <rjafri@nvidia.com> * removed duplicate data type from test Signed-off-by: Raza Jafri <rjafri@nvidia.com> * removed CoalesceExec from allowedOnCpu list because it supports structs now Signed-off-by: Raza Jafri <rjafri@nvidia.com> * Decimals are supported by CoalesceExec Signed-off-by: Raza Jafri <rjafri@nvidia.com> Co-authored-by: Raza Jafri <rjafri@nvidia.com>
* updated Parquet writer support docs Signed-off-by: Raza Jafri <rjafri@nvidia.com> * adding Struct to allow list for ParquetWriter Signed-off-by: Raza Jafri <rjafri@nvidia.com> * add nested struct test Signed-off-by: Raza Jafri <rjafri@nvidia.com> * removed duplicate data type from test Signed-off-by: Raza Jafri <rjafri@nvidia.com> * removed CoalesceExec from allowedOnCpu list because it supports structs now Signed-off-by: Raza Jafri <rjafri@nvidia.com> * Decimals are supported by CoalesceExec Signed-off-by: Raza Jafri <rjafri@nvidia.com> Co-authored-by: Raza Jafri <rjafri@nvidia.com>
Signed-off-by: Raza Jafri rjafri@nvidia.com