Cancel requests that are queued for a client/handler on error #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abellina
added
shuffle
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
abellina
force-pushed
the
shuffle/client_cancel_request_on_completion_and_error
branch
from
d08a569
to
c88f12c
Compare
…ready unique per client
jlowe
reviewed
Jun 2, 2021
shuffle-plugin/src/main/scala/com/nvidia/spark/rapids/shuffle/ucx/UCXShuffleTransport.scala
Outdated
Show resolved
Hide resolved
shuffle-plugin/src/main/scala/com/nvidia/spark/rapids/shuffle/ucx/UCXShuffleTransport.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/shuffle/RapidsShuffleClient.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/shuffle/RapidsShuffleIterator.scala
Show resolved
Hide resolved
jlowe
approved these changes
Jun 3, 2021
|
build |
abellina
deleted the
shuffle/client_cancel_request_on_completion_and_error
branch
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…#2553) * Cancel requests that are queued for a client/handler on error Signed-off-by: Alessandro Bellina <abellina@nvidia.com> * Only need the handler instead of client+handler, as the handler is already unique per client * Apply review comments
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…#2553) * Cancel requests that are queued for a client/handler on error Signed-off-by: Alessandro Bellina <abellina@nvidia.com> * Only need the handler instead of client+handler, as the handler is already unique per client * Apply review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2478
This handles a performance bug that will cancel queued requests if a peer leaves. These are not requests in flight, so a
recvhas not been issued.