Profiling tool: Add support for health check. #2632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…supported SQL Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
nartal1
added
the
task
|
build |
tgravescs
reviewed
Jun 8, 2021
| ``` | ||
| Application application_1616746343401_0025 (index=1) failed tasks: | ||
| +-------+--------------+------+-------+------------------------------------+ | ||
| |stageId|stageAttemptId|taskId|attempt|endReason_first36char | |
There was a problem hiding this comment.
any reason to use 36 char here and 100 below? seems like we could use 100 in both. Maybe put ... at the end of hte string if its longer.
| /** | ||
| * HealthCheck defined health check rules | ||
| */ | ||
| class HealthCheck(apps: ArrayBuffer[ApplicationInfo], textFileWriter:ToolTextFileWriter){ |
| def listFailedJobsStagesTasks(): Unit = { | ||
| for (app <- apps) { | ||
| // Look for failed tasks. | ||
| val tasksMessageHeader = s"Application ${app.appId} (index=${app.index}) failed tasks:\n" |
There was a problem hiding this comment.
I think the rest of the headers leave off the appid and app index, we should be consistent about that.
| @@ -140,6 +140,9 @@ class ApplicationInfo( | |||
| var taskGettingResult: ArrayBuffer[SparkListenerTaskGettingResult] = | |||
| ArrayBuffer[SparkListenerTaskGettingResult]() | |||
|
|
|||
| //Unsupported SQL plan | |||
| // For unsupportedSQLPlanDF | ||
| allDataFrames += (s"unsupportedSQLplan_$index" -> unsupportedSQLplan.toDF) | ||
| if (unsupportedSQLplan.nonEmpty) { | ||
| logInfo(s"Total ${unsupportedSQLplan.size} Plan node accums for appID=$appId") |
There was a problem hiding this comment.
"Plan node accums" is copy and paste from above, change it to something like unsupported ops
|
|
||
| import com.nvidia.spark.rapids.tool.ToolTestUtils | ||
| import org.scalatest.FunSuite | ||
| import scala.collection.mutable.ArrayBuffer |
There was a problem hiding this comment.
nit: scala should go after java and before this section
tgravescs
approved these changes
Jun 8, 2021
This was referenced Jun 8, 2021
nartal1
added a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Profiling tool: Add support to list failed tasks, jobs, stages and unsupported SQL Signed-off-by: Niranjan Artal <nartal@nvidia.com> * add tests for health check features Signed-off-by: Niranjan Artal <nartal@nvidia.com>
nartal1
added a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Profiling tool: Add support to list failed tasks, jobs, stages and unsupported SQL Signed-off-by: Niranjan Artal <nartal@nvidia.com> * add tests for health check features Signed-off-by: Niranjan Artal <nartal@nvidia.com>
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds these features:
list Failed - Jobs, Stages and Tasks
list - RemovedBlockManager()
list - RemovedExecutors()
list - PossibleUnsupportedSQLPlan()
This PR is mainly to include the health related metrics/information of the cluster.
Added new eventlogs which have failed stages, tasks and exectuors removed.
Added tests to validate the API's.