Fix multiple problems reported and improve error handling #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
Signed-off-by: Thomas Graves <tgraves@apache.org>
|
build |
1 similar comment
|
build |
|
This is targeted to branch-21.08. |
|
build |
|
build |
1 similar comment
|
build |
|
pending resource. re-triggered |
nartal1
previously approved these changes
Jun 10, 2021
|
build |
|
build |
|
Please wait to trigger build |
|
build |
1 similar comment
|
build |
17 tasks
nartal1
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2659
uses collect_set instead of collect_list to remove duplicates in potential problems
fixes #2652
Add in better checks before calling into sql and remove system.exit from the application information class that would cause exits vs just skipping applications. I tried to add in useful logging about skipping logs and applications that are bad.
I was trying to make as minimal impacting changes so the checks are a bit of brute force for now.
Added in tests and cleaned up some event logs.