Revert "Add in support for lists in some joins (#2702)" #2749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 44a48ca. Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
|
build |
jlowe
reviewed
Jun 21, 2021
|
#2723 is the issue tracking it from our side. I was thinking the cudf issue can be filed once we have a repro. |
I saw #2723 mostly as tracking the original bug which doesn't necessarily require restoring this revert in order to declare it "fixed," especially if it ends up just being delegated to a cudf issue. I'm OK with #2723 being the tracking issue as long as it's clear in that issue that it must not be considered closed until the functionality being reverted here is restored. |
|
Ok I see what you mean. I'll make it clear in the issue to re-add Bobby's code. It seems like it is the passing criteria for #2723, that the added types and tests pass. |
jlowe
approved these changes
Jun 21, 2021
revans2
approved these changes
Jun 21, 2021
abellina
added a commit
to abellina/spark-rapids
that referenced
this pull request
Jun 25, 2021
…NVIDIA#2749)" This reverts commit b3e7c4b.
mythrocks
added a commit
to mythrocks/spark-rapids
that referenced
this pull request
Jul 21, 2021
…NVIDIA#2749)" This reverts commit b3e7c4b. This re-enables support for lists in Broadcast Nested Loop Joins, and Cartesian joins, as was intended in 2702. Signed-off-by: Mithun RK <mythrocks@gmail.com>
mythrocks
added a commit
that referenced
this pull request
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 44a48ca.
Signed-off-by: Alessandro Bellina abellina@nvidia.com
Due to #2723, we'd like to revert this change while we investigate a solution.