Report equivilant stages/sql ids as a part of compare #2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
revans2
added
the
task
revans2
commented
Jun 23, 2021
|
|
||
| import SparkPlanInfoWithStage._ | ||
|
|
||
| def debugEquals(other: Any, depth: Int = 0): Boolean = { |
There was a problem hiding this comment.
I left this in, because our plugin is constantly changing and we have not really tested this with databricks or others, so if we run into issues, this is a quick way to track down what parts of a plan need to be normalized for the comparison to work properly.
tgravescs
reviewed
Jun 25, 2021
| +-----------------------+-----------------------+ | ||
| |app-20210329165943-0103|app-20210329170243-0018| | ||
| +-----------------------+-----------------------+ | ||
| |0 |0 | |
There was a problem hiding this comment.
would it be helpful to also add time each took? I guess we can always add more later.
There was a problem hiding this comment.
Ya I thought about that, but I didn't want to make it too complicated to start out with.
tgravescs
reviewed
Jun 25, 2021
tools/src/main/scala/com/nvidia/spark/rapids/tool/profiling/CollectInformation.scala
Show resolved
Hide resolved
tools/src/main/scala/com/nvidia/spark/rapids/tool/profiling/ProfileMain.scala
Show resolved
Hide resolved
tools/src/main/scala/com/nvidia/spark/rapids/tool/profiling/ProfileMain.scala
Show resolved
Hide resolved
tools/src/main/scala/org/apache/spark/sql/rapids/tool/profiling/ApplicationInfo.scala
Outdated
Show resolved
Hide resolved
|
build |
tgravescs
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the Profile tool this helps a lot when trying to compare large complicated queries to each other.
This refactored dot generation because I wanted to reused the stage matching part of it, but I needed a better way to do it. I also wanted to be able to output dot graphs as a apart of compare, even if they were not producing a graph that compared the different applications.