Fix cast string to bool #2903
Merged
Fix cast string to bool #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowe
previously approved these changes
Jul 9, 2021
gerashegalov
reviewed
Jul 9, 2021
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
force-pushed
the
fix-cast-string-to-bool
branch
from
3488fb4
to
ed67129
Compare
|
build |
jlowe
approved these changes
Jul 13, 2021
No. I just forgot to change it last night. Updated. |
gerashegalov
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #2898 and closes #2902
In CAST string to bool, we were not removing whitespace and were performing a case-sensitive comparison so we did not recognize
TRUEas a boolean value.The bug fix is in this commit: 3488fb4