Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CAST string to float implementation to handle more edge cases #2933

Merged
merged 20 commits into from
Jul 20, 2021
Merged

Improve CAST string to float implementation to handle more edge cases #2933

merged 20 commits into from
Jul 20, 2021

Commits on Jul 14, 2021

  1. Improve CAST string to float implementation to handle more edge cases 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    1ab4b44 View commit details
    Browse the repository at this point in the history

  2. formatting and an extra test case 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    52c918a View commit details
    Browse the repository at this point in the history

  3. Improve comments 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    cf30f06 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2021

  1. Simply replacement of +Inf with Inf and reduce nesting of transformat… 

    …ions to reduce memory overhead
    @andygrove
    andygrove committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    7105617 View commit details
    Browse the repository at this point in the history

  2. use contains for searching for vertical whitespace 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    e796d1a View commit details
    Browse the repository at this point in the history

  3. Simplify check for nan or float in ansi mode 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    5f00137 View commit details
    Browse the repository at this point in the history

  4. Remove some redundant parenthesis from regex pattern 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    416bc89 View commit details
    Browse the repository at this point in the history

  5. Simply strip designator code 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    c975ec5 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2021

  1. Update sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCast.scala 

    Co-authored-by: Jason Lowe <jlowe@nvidia.com>
    @andygrove @jlowe
    andygrove and jlowe authored Jul 16, 2021
    Configuration menu
    Copy the full SHA
    d830365 View commit details
    Browse the repository at this point in the history

  2. Update sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCast.scala 

    Co-authored-by: Jason Lowe <jlowe@nvidia.com>
    @andygrove @jlowe
    andygrove and jlowe authored Jul 16, 2021
    Configuration menu
    Copy the full SHA
    565a054 View commit details
    Browse the repository at this point in the history

  3. Revert complex regex

    @andygrove
    andygrove committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    3c650b9 View commit details
    Browse the repository at this point in the history

  4. Fix regression

    @andygrove
    andygrove committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    009e3eb View commit details
    Browse the repository at this point in the history

  5. simplify stripping floating point designator

    @andygrove
    andygrove committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    b02f4e6 View commit details
    Browse the repository at this point in the history

  6. improve code readability

    @andygrove
    andygrove committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    b2ac438 View commit details
    Browse the repository at this point in the history

  7. merge from branch-21.08 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    5a95ed4 View commit details
    Browse the repository at this point in the history

  8. Add tests for ansi mode and fix related issues 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    e9906a9 View commit details
    Browse the repository at this point in the history

  9. Fix formatting 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    f1a7f83 View commit details
    Browse the repository at this point in the history

  10. Avoid capturing groups 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    f0e8b45 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2021

  1. Revert change that removed fixed seed 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    1877205 View commit details
    Browse the repository at this point in the history

  2. Add isValid checks 

    Signed-off-by: Andy Grove <andygrove@nvidia.com>
    @andygrove
    andygrove committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    5b823aa View commit details
    Browse the repository at this point in the history