-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge branch-21.08 to branch-21.10 #3000
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes commented tests from WindowFunctionSuite. The null-`ORDER BY` column cases are already tested as part of `window_function_test.py`. Signed-off-by: Mithun RK <mythrocks@gmail.com>
…iling-tools.md with some modification (NVIDIA#2985) * Signed-off-by: Hao Zhu <hazhu@nvidia.com> Move tools README under docs folder. * Signed-off-by: Hao Zhu <hazhu@nvidia.com> Correct some typos of the link * Signed-off-by: Hao Zhu <hazhu@nvidia.com> Fix some typo * Signed-off-by: Hao Zhu <hazhu@nvidia.com> Add more example options for tools doc * Signed-off-by: Hao Zhu <hazhu@nvidia.com> Add a new README for tools. * Update docs/additional-functionality/qualification-profiling-tools.md Co-authored-by: Jason Lowe <jlowe@nvidia.com> * Update docs/additional-functionality/qualification-profiling-tools.md Co-authored-by: Jason Lowe <jlowe@nvidia.com> * Update docs/additional-functionality/qualification-profiling-tools.md Co-authored-by: Jason Lowe <jlowe@nvidia.com> * Update docs/additional-functionality/qualification-profiling-tools.md Co-authored-by: Jason Lowe <jlowe@nvidia.com> * Update docs/additional-functionality/qualification-profiling-tools.md Co-authored-by: Jason Lowe <jlowe@nvidia.com> * Update docs/additional-functionality/qualification-profiling-tools.md Co-authored-by: Jason Lowe <jlowe@nvidia.com> * Update docs/additional-functionality/qualification-profiling-tools.md Co-authored-by: Jason Lowe <jlowe@nvidia.com> * Update docs/additional-functionality/qualification-profiling-tools.md Co-authored-by: Jason Lowe <jlowe@nvidia.com> * Update docs/additional-functionality/qualification-profiling-tools.md Co-authored-by: Jason Lowe <jlowe@nvidia.com> * Update docs/additional-functionality/qualification-profiling-tools.md Co-authored-by: Jason Lowe <jlowe@nvidia.com> * Update tools/README.md Co-authored-by: Jason Lowe <jlowe@nvidia.com> * Update docs/additional-functionality/qualification-profiling-tools.md Co-authored-by: Jason Lowe <jlowe@nvidia.com> * Update docs/additional-functionality/qualification-profiling-tools.md Co-authored-by: Jason Lowe <jlowe@nvidia.com> * Update docs/additional-functionality/qualification-profiling-tools.md Co-authored-by: Jason Lowe <jlowe@nvidia.com> * Update docs/additional-functionality/qualification-profiling-tools.md Co-authored-by: Jason Lowe <jlowe@nvidia.com> * Remove some lines. Co-authored-by: Jason Lowe <jlowe@nvidia.com>
abellina
approved these changes
Jul 22, 2021
mythrocks
approved these changes
Jul 22, 2021
pxLi
approved these changes
Jul 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to merge w/ a merge commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the merge problem identified in #2998 which apparently hiccuped due to a race with code being committed at the same time. The merge was clean.
NOTE: This must be committed with a merge commit, not squashed!