Fix ORC read corruption when specified schema does not match file order #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
This PR first fixes the orc data read mess up for the schema which can't be pruned, and then add the dis-order read schema unit tests for both Parquet and Orc. Signed-off-by: Bobby Wang <wbo4958@gmail.com>
|
build |
jlowe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR first fixes the orc data reading mess up for the schema which can't be pruned
second, adds the dis-order read schema unit tests for both Parquet and Orc.
Please refer to issue #3060.
With this PR, GPU can produce the correct result but The CPU itself has produced the wrong result. So this PR will bring the in-compatible behavior between GPU and CPU.