Remove the struct support in ORC reader #3079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do this because of the issue NVIDIA#3059, which seems not to be easy to fix in a short time. Signed-off-by: Firestarman <firestarmanllc@gmail.com>
|
I will take care of the issue #3059 when enabling the struct support in the future PR for 21.10. |
|
build |
firestarman
changed the title
firestarman
changed the title
firestarman
changed the title
tgravescs
approved these changes
Jul 29, 2021
|
we need an issue to track putting this back and specifically also make sure the test failure gets fixed. |
|
reopened #2879 |
jlowe
approved these changes
Jul 29, 2021
Thanks |
firestarman
added a commit
to firestarman/spark-rapids
that referenced
this pull request
Aug 9, 2021
Also add tests for the nested predicate pushdown, and the support for nested column pruning. Relevant PRs: NVIDIA#3079 NVIDIA#2887 Signed-off-by: Firestarman <firestarmanllc@gmail.com>
firestarman
added a commit
to firestarman/spark-rapids
that referenced
this pull request
Aug 11, 2021
Also add tests for the nested predicate pushdown, and the support for nested column pruning. Relevant PRs: NVIDIA#3079 NVIDIA#2887 Signed-off-by: Firestarman <firestarmanllc@gmail.com>
firestarman
added a commit
to firestarman/spark-rapids
that referenced
this pull request
Aug 17, 2021
Also add tests for the nested predicate pushdown, and the support for nested column pruning. Relevant PRs: NVIDIA#3079 NVIDIA#2887 Signed-off-by: Firestarman <firestarmanllc@gmail.com>
firestarman
added a commit
to firestarman/spark-rapids
that referenced
this pull request
Aug 20, 2021
Also add tests for the nested predicate pushdown, and the support for nested column pruning. Relevant PRs: NVIDIA#3079 NVIDIA#2887 Signed-off-by: Firestarman <firestarmanllc@gmail.com>
firestarman
added a commit
that referenced
this pull request
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this because of the issue #3059, which seems not to be easy to fix in a short time.
closes #3059
Signed-off-by: Firestarman firestarmanllc@gmail.com