Add TypeSig checks for join keys and other special cases #3183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
razajafri
reviewed
Aug 10, 2021
Comment on lines
-235
to
-237
| .withPsNote(TypeEnum.ARRAY, "Cannot be used as join key") | ||
| .withPsNote(TypeEnum.STRUCT, "Cannot be used as join key") | ||
| .withPsNote(TypeEnum.MAP, "Cannot be used as join key") |
There was a problem hiding this comment.
Just so I am not misunderstanding, are these unrelated changes and more like and audit that you ran into while making the doc change?
There was a problem hiding this comment.
Prior to this PR we relied on the "ps notes" to document the fact that we don't support map/struct/array as join keys, but we now have specific lines in the supported_ops table for leftKeys and rightKeys for the join operators, showing which types are supported, so we no longer need these ps notes.
revans2
reviewed
Aug 10, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/TypeChecks.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
revans2
previously approved these changes
Aug 11, 2021
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
changed the title
jlowe
previously approved these changes
Aug 13, 2021
|
build |
revans2
reviewed
Aug 16, 2021
shims/spark311db/src/main/scala/com/nvidia/spark/rapids/shims/spark311db/Spark311dbShims.scala
Outdated
Show resolved
Hide resolved
|
build |
revans2
previously approved these changes
Aug 17, 2021
revans2
approved these changes
Aug 17, 2021
|
build |
razajafri
pushed a commit
to razajafri/spark-rapids
that referenced
this pull request
Aug 23, 2021
Signed-off-by: Andy Grove <andygrove@nvidia.com> Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Grove andygrove@nvidia.com
Closes #2102
This PR allows us to provide TypeSig signatures for join keys and generates appropriate documentation in support_ops.md
This is implemented for joins and WindowExec.