Fix Parquet test_round_trip to avoid CPU write exception #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
revans2
approved these changes
Aug 11, 2021
|
Unrelated tests are failing, looks like the executor just mysteriously hung up. |
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3195.
#3175 added timestamp generation to maps, and Parquet has issues writing old timestamps even on the CPU for Spark 3.1+ unless the new
spark.sql.legacy.parquet.int96RebaseModeInWriteis set properly.I updated the parquet tests to set the int96 rebase config to match the datetime rebase config so we'll get the expected behavior when writing on the CPU whether it's Spark 3.0.x or Spark 3.1+. I also updated the parquet test to use a limited timestamp range for the timestamps within maps.