Add UCX 1.11.0 to the pre-merge Docker image #3218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
abellina
requested review from
GaryShen2008,
jlowe,
NvTimLiu,
revans2 and
tgravescs
as code owners
pxLi
previously approved these changes
Aug 12, 2021
|
build |
pxLi
reviewed
Aug 12, 2021
pxLi
approved these changes
Aug 12, 2021
|
build |
zhanga5
reviewed
Aug 12, 2021
| FROM nvidia/cuda:${CUDA_VER}-runtime-ubuntu${UBUNTU_VER} | ||
| ARG CUDA_VER |
There was a problem hiding this comment.
no this is required so we can use the ARG after the FROM.
There was a problem hiding this comment.
@zhanga5 as Alessandro said, this is a must have.
We put arg before FROM to make the image name, and need to re-declare to make sure we can still access it after FROM since they are different stages in docker images~
zhanga5
approved these changes
Aug 12, 2021
|
new image has been pushed, and will be used in all upcoming pre-merge CIs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alessandro Bellina abellina@nvidia.com
Splits off the addition of UCX 1.11 to the CI dockerfile we use for premerge. The next PR should enable tests, but this needs to be done first so we have the image with UCX pushed.