Fix some resource leaks in GpuCast and RapidsShuffleServerSuite #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
Note that viewing the diff with whitespace changes hidden should help with the GpuCast change. |
|
build |
abellina
approved these changes
Aug 16, 2021
revans2
approved these changes
Aug 16, 2021
razajafri
pushed a commit
to razajafri/spark-rapids
that referenced
this pull request
Aug 23, 2021
…IA#3231) Signed-off-by: Jason Lowe <jlowe@nvidia.com> Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed some warnings about leaked resources in the detailed test log, and upon investigating I found a few leaks. In the case of GpuCast, a column vector was being leaked if we threw an exception due to ANSI mode checks. For RapidsShuffleServerSuite, the
getBufferSendStatemethod returns an instance that must be closed but the tests were failing to do so.