Support Databricks 3.0.1 with new build profiles #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
…rapids into buildsparkdb301
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
tgravescs
requested review from
GaryShen2008,
jlowe,
NvTimLiu and
revans2
as code owners
|
build |
jlowe
reviewed
Aug 31, 2021
There was a problem hiding this comment.
For some reason the use of S{spark.version} for all the non-Spark jars struck me this time, surprised I didn't notice it before. This is done in a lot of places, so I didn't put a comment for each one. Not sure it absolutely has to have a comment, but it sure did look weird and wrong when I noticed it.
jlowe
previously approved these changes
Aug 31, 2021
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
…nto buildsparkdb301
|
build |
jlowe
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #3224
Add support for databricks 3.0.1 with new build profiles. In this case so prevent having to copy all the dependencies for data bricks 3.1.1 into a profile for 3.0.1 I made another profiles dbdeps that is triggered by property -Ddatabricks.
If we want to remove this we can and we can just copy them.
I also ran into a bug with the scala-maven-plugin where I had to go back to an older version.
Also clean up some build warnings.
build command is like:
mvn -Ddatabricks -Dbuildver=301db package