Batch scalastyle checks across all modules upfront #3433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replaces scalastyle-maven-plugin with an ant task, uses compact wildcard paths so we don't need to hardcode evolving source code layout - checks all modules in one go upfront so the developers don't have to wait for failures incurred later after lengthy scala builds - fixes codestyle violations accummulated while the check was incomplete Fixes NVIDIA#3388 Signed-off-by: Gera Shegalov <gera@apache.org>
gerashegalov
requested review from
GaryShen2008,
jlowe,
NvTimLiu,
revans2 and
tgravescs
as code owners
gerashegalov
changed the title
gerashegalov
changed the title
|
build |
jlowe
previously approved these changes
Sep 10, 2021
|
looking into 311db failure |
|
build |
tgravescs
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3388
Signed-off-by: Gera Shegalov gera@apache.org