-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regressions in cast from string to date and timestamp #3485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
build |
andygrove
commented
Sep 14, 2021
@@ -960,30 +959,6 @@ class CastOpSuite extends GpuExpressionTestSuite { | |||
} | |||
} | |||
|
|||
test("CAST string to date - sanitize step") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is no longer needed since we no longer have the sanitization step
andygrove
changed the title
WIP: Fix regressions in cast from string to date and timestamp
Fix regressions in cast from string to date and timestamp
Sep 15, 2021
andygrove
changed the title
Fix regressions in cast from string to date and timestamp
WIP: Fix regressions in cast from string to date and timestamp
Sep 15, 2021
andygrove
changed the title
WIP: Fix regressions in cast from string to date and timestamp
Fix regressions in cast from string to date and timestamp
Sep 15, 2021
revans2
approved these changes
Sep 15, 2021
build |
1 similar comment
build |
The last build failure looked like a networking issue (could not fetch from github...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Grove andygrove@nvidia.com
Partially addresses #3478
cuDF recently started supporting variable-length date/timestamp components in
is_timestamp
and when parsing strings as timestamps. This caused regressions in the plugin.This PR fixes the regressions and has the following changes:
We also now support single digit hour, minute and second in timestamps. We still require 6 digits for fractional second.