Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3468
Add the GpuKryoRegistrator class to common unshimmed code and add the actual registration into the shim. This made more sense to me to add into the shim module since its not create a new instance but just references the class by the spark version shim and I expect this code to be commonized when we commonize the base shim code. If people have strong objections we can rework it but we haven't really put anything into the ShimLoader class like this yet.
I built all versions, tested on all apache versions. We need overrides to test cdh and need to figure out how to test on Databricks.
Signed-off-by: Thomas Graves tgraves@nvidia.com