Unshim ExclusiveModeGpuDiscoveryPlugin #3590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As one of the publicly documented classes loaded by Spark outside the plugin control, ExclusiveModeGpuDiscoveryPlugin may not reside in the Parallel World locations. Binary dedupe shows ExclusiveModeGpuDiscoveryPlugin is bitwise-identical across all shims Signed-off-by: Gera Shegalov <gera@apache.org>
|
|
build |
…veModeGpuDiscoveryPlugin
tgravescs
previously approved these changes
Sep 21, 2021
|
build |
|
we need to finish testing this manually |
via ShimLoader Signed-off-by: Gera Shegalov <gera@apache.org>
tgravescs
reviewed
Sep 22, 2021
|
weird ci hasn't reported, I don't see anything running, kicking again |
|
build |
|
I tried this out manually and its working for me as well: |
|
failed with the scalastyle issue because of import order I mention above |
|
build |
tgravescs
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3589
As one of the publicly documented classes loaded by Spark outside the
plugin control, ExclusiveModeGpuDiscoveryPlugin may not reside in the
Parallel World locations. Binary dedupe shows
ExclusiveModeGpuDiscoveryPlugin is bitwise-identical across all shims
Signed-off-by: Gera Shegalov gera@apache.org