CollectSet supports structs #3700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bobby Wang <wbo4958@gmail.com>
|
build |
|
We should test this on DB as well? |
revans2
reviewed
Sep 29, 2021
|
build |
wbo4958
changed the title
|
build |
wbo4958
changed the title
Done |
|
Please retarget to branch-21.12. |
revans2
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #3514 and #3152. Currently, with this PR, the CollectSet on structs can run on GPU. Since CPU and GPU can't ensure the order of collect-set, we need to add sort_array on collect-set. But for now, sort-array didn't support on nested type, I just xfail the newly added collect-set test on structs.