Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable timestamp read tests for Parquet and ORC #3758

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Temporarily disable timestamp read tests for Parquet and ORC #3758

merged 1 commit into from
Oct 7, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Oct 6, 2021

Temporarily disables timestamp-related Parquet and ORC read tests until #3742 is fixed.

@jlowe
Temporarily disable timestamp read tests for Parquet and ORC
d930f01 
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe added the test Only impacts tests label Oct 6, 2021
@jlowe jlowe added this to the Oct 4 - Oct 15 milestone Oct 6, 2021
@jlowe jlowe self-assigned this Oct 6, 2021
@jlowe
Copy link
Member Author

jlowe commented Oct 6, 2021

build

tgravescs
tgravescs approved these changes Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@tgravescs tgravescs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failure is due to 3.2 change to block manager

@jlowe
Copy link
Member Author

jlowe commented Oct 6, 2021

build

razajafri
razajafri reviewed Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@razajafri razajafri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If reading timestamps is a problem then did we miss test_reading_from_unaligned_pages_all_types and
test_reading_from_unaligned_pages_all_types_dict_optimized in parquet_test.py?

@jlowe jlowe merged commit 99afae6 into NVIDIA:branch-21.12 Oct 7, 2021
@jlowe
Copy link
Member Author

jlowe commented Oct 7, 2021

If reading timestamps is a problem then did we miss test_reading_from_unaligned_pages_all_types and
test_reading_from_unaligned_pages_all_types_dict_optimized in parquet_test.py?

Those tests weren't failing so I didn't disable them. I verified all tests pass after the latest changes in rapidsai/cudf#9382, so I'll revert this when we have a cudf snapshot with that change.

@jlowe jlowe deleted the temp-disable-timestamp-read-tests branch October 7, 2021 13:03
jlowe added a commit to jlowe/spark-rapids that referenced this pull request Oct 8, 2021
@jlowe
Revert "Temporarily disable timestamp read tests for Parquet and ORC (N…
fd2d37c 
…VIDIA#3758)"

This reverts commit 99afae6.
@jlowe jlowe mentioned this pull request Oct 8, 2021
Merged
jlowe added a commit to jlowe/spark-rapids that referenced this pull request Oct 8, 2021
@jlowe
Revert "Temporarily disable timestamp read tests for Parquet and ORC (N…
56aff39 
…VIDIA#3758)"

This reverts commit 99afae6.

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
jlowe added a commit that referenced this pull request Oct 8, 2021
@jlowe
Revert "Temporarily disable timestamp read tests for Parquet and ORC (#…
b9127aa 
…3758)" (#3773)

This reverts commit 99afae6.

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razajafri razajafri razajafri left review comments

@abellina abellina abellina approved these changes

@tgravescs tgravescs tgravescs approved these changes

Assignees

@jlowe jlowe

Labels
test Only impacts tests
Projects
None yet
Milestone
Oct 4 - Oct 15
Development

Successfully merging this pull request may close these issues.
4 participants
@jlowe @abellina @tgravescs @razajafri